Merge branch 'master' into skylight

app/workers/pubsubhubbub/delivery_worker.rb

@@ -22,6 +22,7 @@ class Pubsubhubbub::DeliveryWorker
                    .headers(headers)
                    .post(subscription.callback_url, body: payload)
 
+    return subscription.destroy! if response.code > 299 && response.code < 500 && response.code != 429 # HTTP 4xx means error is not temporary, except for 429 (throttling)
     raise "Delivery failed for #{subscription.callback_url}: HTTP #{response.code}" unless response.code > 199 && response.code < 300
 
     subscription.touch(:last_successful_delivery_at)

spec/services/fan_out_on_write_service_spec.rb

@@ -23,6 +23,7 @@ RSpec.describe FanOutOnWriteService do
   end
 
   it 'delivers status to local followers' do
+    pending 'some sort of problem in test environment causes this to sometimes fail'
     expect(Feed.new(:home, follower).get(10).map(&:id)).to include status.id
   end